module.exports.add - Code Metrics - Inspection of "Merge pull request #38 from garyvv/develop" - garyvv/node-sharp - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 1adf40...f067da )

by lv

created 2018-07-31 16:10 UTC

module.exports.add A

↳ Parent: app/services/catering/desk.js

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	9
c	0
b	0
f	0
nc	1
dl	0
loc	13
rs	9.95
nop	2

const ModelDesk = require('../../model/catering/desk')
const ApiError = require('../../util/api_error')
const Validate = require('request-validate')
const _ = require('underscore')

module.exports = {
    list: async function (storeId) {
        let result = await ModelDesk.list(storeId)
        return result
    },

    detail: async function (storeId, id) {
        let result = await ModelDesk.first(id)
        if (_.isEmpty(result)) {
            throw new ApiError('common.notExist', 'desk')
        }

        if (result.store_id != storeId) {
            throw new ApiError('common.notExist', 'desk')
        }

        if (result.status == -1) {
            throw new ApiError('common.notExist', 'desk')
        }
        
        return result
    },

    add: async function (storeId, data) {
        Validate(data, {
            name: 'required',
        })
        let insertData = {
            store_id: storeId,
            name: data.name
        }
        let insertResult = await ModelDesk.add(insertData)
        insertData.id = insertResult.insertId

        return insertData
    },

    edit: async function (storeId, id, data) {
        let detail = await this.detail(storeId, id)

        let where = {
            id: id
        }

        let updateData = {
            name: _.has(data, 'name') ? data.name : detail.name,
            status: _.has(data, 'status') ? data.status : detail.status
        }

        let editResult = await ModelDesk.edit(updateData, where)


        return updateData
    },

}


1			const ModelDesk = require('../../model/catering/desk')
2			const ApiError = require('../../util/api_error')
3			const Validate = require('request-validate')
4			const _ = require('underscore')
5
6			module.exports = {
7			list: async function (storeId) {
8			let result = await ModelDesk.list(storeId)
9			return result
10			},
11
12			detail: async function (storeId, id) {
13			let result = await ModelDesk.first(id)
14			if (_.isEmpty(result)) {
15			throw new ApiError('common.notExist', 'desk')
16			}
17
18			if (result.store_id != storeId) {
19			throw new ApiError('common.notExist', 'desk')
20			}
21
22			if (result.status == -1) {
23			throw new ApiError('common.notExist', 'desk')
24			}
25
26			return result
27			},
28
29			add: async function (storeId, data) {
30			Validate(data, {
31			name: 'required',
32			})
33			let insertData = {
34			store_id: storeId,
35			name: data.name
36			}
37			let insertResult = await ModelDesk.add(insertData)
38			insertData.id = insertResult.insertId
39
40			return insertData
41			},
42
43			edit: async function (storeId, id, data) {
44			let detail = await this.detail(storeId, id)
45
46			let where = {
47			id: id
48			}
49
50			let updateData = {
51			name: _.has(data, 'name') ? data.name : detail.name,
52			status: _.has(data, 'status') ? data.status : detail.status
53			}
54
55			let editResult = await ModelDesk.edit(updateData, where)
			0 ignored issues – show Unused Code introduced 2018-07-31 16:02 UTC by Report Bug Copy Issue Report The variable `editResult` seems to be never used. Consider removing it. Loading history...
56
57			return updateData
58			},
59
60			}
61

garyvv / node-sharp

Push — master ( 1adf40...f067da )

module.exports.add A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like